search

North-West-Wind / forge-autofish

The GitHub repo for AutoFish for Forge
GNU General Public License v3.0
22 stars 3 forks source link

Rod not reeling in #15

Open secret-dinosaur opened 2 years ago

secret-dinosaur commented 2 years ago

Describe the Bug: When the bobber moves down to indicate a fish has attached to the rod, the rod does not reel in and any potential catch is lost.

To Reproduce: Settings:

Stand facing an open ocean with the fishing rod in hand. Right click with the fishing rod so that the bobber sits out on the water. Leave the keyboard and mouse untouched while the fish particles generate, approach the bobber in the water, and drag it down.

NOTE: the fishing rod has the Lure 1 enchantment

Expected behaviour: The fish particles move towards the bobber in the water. The bobber moves down a little ways and the rod is then reeled in and the player receives one of the fishing rewards (fish, junk, etc.). This is what occurred for the first minute or so after the mod was installed.

Screenshots https://vimeo.com/665419934

I'm really sorry if this ends up being an issue on my side. I tried not to touch the settings (k) tab because I have no clue what most of it is referring to. It was working fine for a little bit but then I noticed that the rod was remaining in the water and not reeling in any catches. That's when I pushed the recast delay up to 25 from 20 and started trying different combinations of the key-bound settings to try and get it to work again.

secret-dinosaur commented 2 years ago

Forgot to add: this is for version 1.18.1 with the 1.18.x file

Tokerot commented 2 years ago

to add on to this i believe i have the same issue, after casting autofish works for a couples minutes then eventually stops reeling in. a client restart usually fixes this

whitegod1954 commented 2 years ago

this is for version 1.18.2 with the 4.0.2 file same issue stops reeling and after "Enchant" ended

North-West-Wind commented 2 years ago

This will be the next thing to fix. Unfortunately, I will be very busy on academics for this and the next month, so this will need to wait. If anyone fork this project and fix the issue, it will be much appreciated.

SkilledAlpaca commented 2 years ago

Same issue on 1.18.2. Client restart resolves the issue. I thought it was a mod conflict but I just tested with just Forge 40.1.20 and AutoFish 4.1.0-1.18.2 with the same issue present.

Edit: It seems that removing rotten flesh from the filter and not having any items in it resolves the issue.