search

North-Western-Development / oc2r

RISC-V VMs in Minecraft. Continued by North Western Development, originally by Sangar.
https://www.curseforge.com/minecraft/mc-mods/oc2r
Other
75 stars 11 forks source link

Support both Forge and Fabric #3

Open ajh123 opened 4 months ago

ajh123 commented 4 months ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I play a Fabric modpack (and many other people do) and I would like to play OC2 on Fabric 1.20.1

Describe the solution you'd like A clear and concise description of what you want to happen.

Use something like Architectury. This will allow you to have a "common" Java project which is shared between two Forge and Fabric projects. All the work would be done inside the "common" project e.g. creating block entities. The purposes of the Forge and Fabric projects is to initialize the mod and contain some platform dependent code (e.g. interacting with energy APIs).

Architectury will save development time because code will only need to be written once.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

  1. Maintaining two separate / independent Forge and Fabric versions, this will mean code will need to be written twice for each platform.
  2. use the same method as CC-Tweaked uses, this is more complex to set up then Architectury however it works without needing Architectury.

Additional context Add any other context or screenshots about the feature request here.

Sangar is planning to port their version of OC2 to Architectury and likes using Architectury for their other mods. ( see comment ) Maybe, once OC2R has done this they could send a PR to the original OC2?

ajh123 commented 4 months ago

I've just looked at the Cursforge page for this mod and it looks like this is planned!

Currently only Forge is supported by this port, however moving to Architectury and supporting both Fabric and Forge is planned for the future!

Is there an estimate for when a development branch will be available?

hickorysb commented 4 months ago

Fabric support and a move to Architectury isn't planned until 1.21 at this point. 1.20.1 will primarily focus on making the mod more stable and improving performance in it's current state.

ThatKid1351 commented 3 months ago

@ajh123 I thought OC2 was abandoned, given how there hasn't been any commit activity in 2 years. Maybe I don't understand GitHub enough?

ThatKid1351 commented 3 months ago

Replying to:

Sangar is planning to port their version of OC2 to Architectury and likes using Architectury for their other mods. ( see comment ) Maybe, once OC2R has done this they could send a PR to the original OC2?

ajh123 commented 3 months ago

@ThatKid1351

You are correct however ...

  1. OC2 was abandoned due to problems with the RISC-V library (Sedna)
  2. a contributor has now fixed those problems.
  3. I've made an issue (for original OC2) asking for Architectury
  4. Sangar replied and said using Architectury was their plan (they have updated their other mods to use Architectury and likes it) - however that hasn't been done yet for OC2
  5. I've found OC2R and asked for the same thing
  6. OC2R developers like using Architectury too but haven't done it yet

That's where we are today, no development for Architectury have been done however all developers like the idea of it.

Maybe the code is being worked on but not publicly released yet?

hickorysb commented 3 months ago

Architectury support, and by extension Fabric support, will be worked on when a port to 1.21 is considered. Right now stability and minor improvements are front and center, though another project is underway that has priority right now as overall there seems to be more interest in that one. It's not ready for a full public announcement though.