NorthArrowResearch / champ-workbench

http://workbench.northarrowresearch.com/
GNU General Public License v3.0
0 stars 0 forks source link

Validation metrics start consuming #38

Closed MattReimer closed 7 years ago

MattReimer commented 7 years ago

Workbench needs to start consuming validation metrics:

Here's how it looks

{
    "metricSchemaUrl": "https://api.CHaMPMonitoring.org/api/v1/Visit/metricschemas/QA - Topo Visit Validation",
    "itemUrl": "https://api.CHaMPMonitoring.org/api/v1/visits/228",
    "values": [
        {
            "name": "GenerationDate",
            "value": "2017-08-02T21:32:35.764Z",
            "type": "String"
        },
        {
            "name": "Status",
            "value": "Fail",
            "type": "String"
        },
        {
            "name": "Errors",
            "value": "1",
            "type": "Numeric"
        },
        {
            "name": "Warnings",
            "value": "37",
            "type": "Numeric"
        },
        {
            "name": "NotTested",
            "value": "13",
            "type": "Numeric"
        },
        {
            "name": "BIslands",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "DEM",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "Bankfull",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "Channel_Units",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "WIslands",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "AssocSlope",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "Topo_Points",
            "value": "Fail",
            "type": "String"
        },
        {
            "name": "AssocRough",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "BankfullXS",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "Thalweg",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "BankfullCL",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "Detrended",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "Water_Depth",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "EdgeofWater_Points",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "Breaklines",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "WSEDEM",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "WaterExtent",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "AssocPDensity",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "WettedXS",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "Stream_Features",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "CenterLine",
            "value": "Pass",
            "type": "String"
        },
        {
            "name": "Control_Points",
            "value": "Pass",
            "type": "String"
        }
    ],
    "name": "f31eb7ca-b0b7-4734-8cba-00d0f50365be",
    "url": "https://api.CHaMPMonitoring.org/api/v1/Visit/metricschemas/QA - Topo Visit Validation/metrics/f31eb7ca-b0b7-4734-8cba-00d0f50365be"
}
volkcj commented 7 years ago

it would be ideal if the validation test description was available as well--I believe there's another attribute beyond 'name' that describes the check. if this isn't readily available via the api, then perhaps this could be included as a lookup table in the workbench?

MattReimer commented 7 years ago

@volkcj There are two ways to get at this data:

  1. Include it in the schema (the downside is that it adds 300 metrics to this list)
  2. pull it out of the validation.xml file on S3

I'm not sure either of these constitutes a "good" option but I'll discuss with @philipbaileynar and see if we can't figure something out.

philipbaileynar commented 7 years ago

The Workbench is now consuming validation metric schema.

https://www.youtube.com/watch?v=GIgsrr5i2gM