Fix Background Tasks (Python3)

jeeftor commented 2 years ago

I made a few changes here mostly dealing with pickle / cpickle and how python3 handles strings. Local testing seems to fix some of the issues I was seeing - which in summary are the following:

Default CacheDIR wasn't being picked up by background process - so I just got rid of the Alfred 2 version and moved to the Alfred 4
There were issues with how strings were getting encoded relating to Python3 - removed string-specific logic and pickle now seems to handle them fine.

I also updated the pre-commit hooks to add Mypy - but realized thats WAY too much for this PR so its commented out.

Using these changes I got my emoji plugin downloading files again with reporting:

jeeftor commented 2 years ago

I'm not fully sure how to get the testing suite up and running locally as of yet ...

jeeftor commented 2 years ago

I haven't managed to mess with the tox testing setup - but my emojitaco plugin is now working again with these changes ... so I'll call it a win :)

NorthIsUp commented 2 years ago

this looks like good work but the tests are unhappy for some reason now.

jeeftor commented 2 years ago

We're they passing before? I thought they weren't. I'm headed on vacation for 5 days. Can try to look when I return

NorthIsUp commented 2 years ago

Much appreciated. If I get to it first I’ll document here On Apr 13, 2022, 04:12 -0700, Jeef @.***>, wrote:

We're they passing before? I thought they weren't. I'm headed on vacation for 5 days. Can try to look when I return — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

NorthIsUp / alfred-workflow-py3

Fix Background Tasks (Python3) #5