Northeastern-Electric-Racing / Argos

Our full-stack data visualization tool
GNU Affero General Public License v3.0
1 stars 0 forks source link

#209 allow for arrowing through graph screen values/tabs #217

Closed somshrivastava closed 3 weeks ago

somshrivastava commented 1 month ago

Changes

In the graph-page component, I added a Host Listener that is listening for any keyboard events... if it is a down or up arrow, I wrote some logic (pretty long, I'm not sure if there is a more efficient way to write it) that will change the selected data type to show the graph of.

From the graph-page component, I passed the selectedDataType value through its child components all the way to the graph-sidebar-desktop component where it can then use the selectedDataType to figure out which dropdown (node) to open.

To Do

There is still a small bug right now. Let's say you open the graph page and click the down arrow, it will open the first dropdown and open the first data type, but it won't show that data type as highlighted to show that it is selected. This happens to the first data type of every dropdown... I'm not sure why. I put a screenshot below of the error.

image

Checklist

It can be helpful to check the Checks and Files changed tabs. Please review the contributor guide and reach out to your Tech Lead if anything is unclear. Please request reviewers and ping on slack only after you've gone through this whole checklist.

Closes # (issue #)

somshrivastava commented 1 month ago

When arrowing through the tabs, if you are on the first data type of any node, it won't show it as selected... not sure why yet, still trying to fix it.

Screenshot 2024-10-07 at 1 08 32 PM