Right now we have 2 pipes that are actually angular pipes (file names: data-type-filter-pipe.ts, node-filter-pipe.ts).
I say 2 actual pipes, because there are also util functions that have pipe in there name (but that will be another ticket). ONLY CHANGE: data-type-filter-pipe.ts, node-filter-pipe.ts
TLDR: just change data-type-filter-pipe.ts, node-filter-pipe.ts to data-type-filter.pipe.ts, node-filter.pipe.ts (just replace the - before the pipe with a . )
Change data-type-filter-pipe.ts, node-filter-pipe.ts to data-type-filter.pipe.ts, node-filter.pipe.ts (just replace the - before the pipe with a . )
ALSO, make sure that argos still runs, and the places where the two pipes are used (which will be in templates) are still transferring data correctly.
Proposed Solution
Read above. + when you are searching for where the two pipes are keyword search for the given pipe name, I'll give you the first one for data-type-filter-pipe.ts: dataTypeFilter taken from (in the file):
@Pipe({ name: 'dataTypeFilter' })
keyword search in vsCode can just be done with the % in the search bar.
Description
Right now we have 2 pipes that are actually angular pipes (file names: data-type-filter-pipe.ts, node-filter-pipe.ts).
I say 2 actual pipes, because there are also util functions that have pipe in there name (but that will be another ticket). ONLY CHANGE: data-type-filter-pipe.ts, node-filter-pipe.ts
TLDR: just change data-type-filter-pipe.ts, node-filter-pipe.ts to data-type-filter.pipe.ts, node-filter.pipe.ts (just replace the - before the pipe with a . )
Here is a link to the Pipes docs in Angular (if you see anything else where we could use a pipe instead of function you can add those changes on to this ticket): https://angular.dev/tutorials/learn-angular/24-create-a-pipe
Acceptance Criteria
Change data-type-filter-pipe.ts, node-filter-pipe.ts to data-type-filter.pipe.ts, node-filter.pipe.ts (just replace the - before the pipe with a . )
ALSO, make sure that argos still runs, and the places where the two pipes are used (which will be in templates) are still transferring data correctly.
Proposed Solution
Read above. + when you are searching for where the two pipes are keyword search for the given pipe name, I'll give you the first one for data-type-filter-pipe.ts: dataTypeFilter taken from (in the file):
@Pipe({ name: 'dataTypeFilter' })
keyword search in vsCode can just be done with the % in the search bar.
Any questions or weird stuff, ask Reid / Wyatt.
Mocks
No response