Currently BMS faults are based on stacked bitwise identifiers (however, right now they are detected based on stacking). With an update to embedded base BMS faults are now based on topic.
Also faults are currently triggered whenever we get a message were the fault is on... however that fault is spammed until the car is reset.
Expected Behavior
BMS faults should be changed to detect faults based on individual topics.
Faults of the same type should not be re-triggered, unless we get a message from the topic of fault off(0).
Observed Behavior
Currently BMS faults are based on stacked bitwise identifiers (however, right now they are detected based on stacking). With an update to embedded base BMS faults are now based on topic.
Also faults are currently triggered whenever we get a message were the fault is on... however that fault is spammed until the car is reset.
Expected Behavior
BMS faults should be changed to detect faults based on individual topics. Faults of the same type should not be re-triggered, unless we get a message from the topic of fault off(0).
Steps to Reproduce
Screenshots (as needed)
No response