Okay so basically I did all the adjustments that I wanted to do from my last PR and some more cuz cleanup is good whatever lol. Turns out I could get rid of the useEffect hook refetch if I just had a flexible object for query parameters instead of function parameters. I expended the work package endpoint to have enough query parameters to replace the separate upcoming deadlines endpoint so that's good. Also had to ensure that query params were included in query keys or else it would use the same resulting data for both instances of the same hook no matter the input. Good to know react-query is smart.
Test Cases
improved testing by testing the url function for work package query parameters urls
Screenshots (if applicable)
Now that's a proper home page
Checklist
It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your squad if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
[x] All commits are tagged with the ticket number
[x] No linting errors
[x] No newline at end of file warnings
[x] All code follows repository-configured prettier formatting
[x] No merge conflicts
[x] All checks passing
[x] Screenshots of UI changes (if applicable)
[x] Remove any not-applicable sections
[x] Assign the PR to yourself
[x] PR is linked to the ticket
[x] No package-lock.json changes (unless dependencies have changed)
Changes
Okay so basically I did all the adjustments that I wanted to do from my last PR and some more cuz cleanup is good whatever lol. Turns out I could get rid of the useEffect hook refetch if I just had a flexible object for query parameters instead of function parameters. I expended the work package endpoint to have enough query parameters to replace the separate upcoming deadlines endpoint so that's good. Also had to ensure that query params were included in query keys or else it would use the same resulting data for both instances of the same hook no matter the input. Good to know
react-queryis smart.Test Cases
improved testing by testing the url function for work package query parameters urls
Screenshots (if applicable)
Now that's a proper home page
Checklist
It can be helpful to check the
ChecksandFiles changedtabs. Please review the contributor guide and reach out to your squad if anything is unclear. Please request reviewers and ping on slack only after you've gone through this whole checklist.package-lock.jsonchanges (unless dependencies have changed)Closes #729