Northeastern-Electric-Racing / PM-Dashboard-v2

Northeastern Electric Racing Project Management Dashboard - version 2
https://nerpm.netlify.app
GNU Affero General Public License v3.0
15 stars 2 forks source link

#666 - Removed the spread operator wherever it appeared in the code #747

Closed tigerhippo closed 2 years ago

tigerhippo commented 2 years ago

Changes

I removed the spread operator wherever it appeared in the code.

Notes

I am not sure what to input for the fields projectLead and projectManager on lines 155 and 156 respectively. I did workPackage.wbsElement.projectLead and workPackage.wbsElement.projectManager (which should work because the WbsElement interface had all of these fields). However, the error message stated that the wbsElement did not have any of these fields.

I still need to test my code, but it would be great if someone could take a look at all the places where I removed the spread operator to see if I did it correctly!

anthonybernardi commented 2 years ago

i swear the package-lock is the exact same as the one on main. Go check line ~1496 for proof that the diff is wrong

anthonybernardi commented 2 years ago

image

this makes no sense and it's the same as on main so im merging this