I changed things around so that we utilize the PageBlock wherever possible, but bespoke card usage is okay too and acknowledged as taking more work with the theme hook. I also took the opportunity to make the PageBlock component better than before by making headreRight optional and using children instead of a manual body parameter.
Notes
Basically I decided it was too much work and not worth it to make an abstract card component, but utilizing what we have already more often seems like a good idea to me.
Screenshots (if applicable)
Thin white border from using page block for filters too now.
Checklist
It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your squad if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
[x] All commits are tagged with the ticket number
[x] No linting errors
[x] No newline at end of file warnings
[x] All code follows repository-configured prettier formatting
[x] No merge conflicts
[x] All checks passing
[x] Screenshots of UI changes (if applicable)
[x] Remove any not-applicable sections
[x] Assign the PR to yourself
[x] PR is linked to the ticket
[x] No package-lock.json changes (unless dependencies have changed)
Changes
I changed things around so that we utilize the
PageBlockwherever possible, but bespoke card usage is okay too and acknowledged as taking more work with the theme hook. I also took the opportunity to make the PageBlock component better than before by makingheadreRightoptional and usingchildreninstead of a manualbodyparameter.Notes
Basically I decided it was too much work and not worth it to make an abstract card component, but utilizing what we have already more often seems like a good idea to me.
Screenshots (if applicable)
Thin white border from using page block for filters too now.
Checklist
It can be helpful to check the
ChecksandFiles changedtabs. Please review the contributor guide and reach out to your squad if anything is unclear. Please request reviewers and ping on slack only after you've gone through this whole checklist.package-lock.jsonchanges (unless dependencies have changed)Closes #737