search

Northeastern-Electric-Racing / PM-Dashboard-v2

Northeastern Electric Racing Project Management Dashboard - version 2
https://nerpm.netlify.app
GNU Affero General Public License v3.0
15 stars 2 forks source link

#554 changed 'wbs element status' to 'status' in the work-packages-edit.ts… #760

Closed tigerhippo closed 2 years ago

tigerhippo commented 2 years ago

I changed 'wbs element status' to just 'status' in the work-packages-edit.ts file.

I was initially going to change 'wbs element status' to 'work package status', because the file relates to work packages, and that would be easier for the user to understand than stating 'wbs element' (which the user likely doesn't know about). However, after discussing with Anthony, I decided to change 'wbs element status' to just 'status', because this would keep everything consistent (none of the other fields have 'wbs element' in front of them, even though they could). It is also pretty obvious to the user what the status is referring to (they know that it is referring to a work package, because they have just created a work package).

An image of my change is below.

Screen Shot 2022-07-07 at 12 02 20 PM

I have already completed 'npm run test' and ran all test suites on my code, which worked fine.

It would be great if someone could review my change!

tigerhippo commented 2 years ago

Since the image didn't show up in the first comment, here it is:

Screen Shot 2022-07-07 at 12 02 20 PM