Northeastern-Electric-Racing / PM-Dashboard-v2

Northeastern Electric Racing Project Management Dashboard - version 2
https://nerpm.netlify.app
GNU Affero General Public License v3.0
15 stars 2 forks source link

#765 remove empty css files #766

Closed RChandler234 closed 2 years ago

RChandler234 commented 2 years ago

Changes

Removed Empty CSS files

Test Cases

Smoke test to make sure that nothing in the application is broken/ looks weird

Checklist

It can be helpful to check the Checks and Files changed tabs. Please review the contributor guide and reach out to your squad if anything is unclear. Please request reviewers and ping on slack only after you've gone through this whole checklist.

Closes # (issue #)

anthonybernardi commented 2 years ago

Nothing better than a PR that looks like this:

Screen Shot 2022-07-18 at 9 39 57 PM
RChandler234 commented 2 years ago

I couldn't move all the css over, some was too complex to put into a jsx object; I suggest we make a stylesheets folder for the frontend and move the remaining ones there for now and try to find a more consistent way to handle having css in a tsx file (there are ways, but it'd involved adding more packages/ bigger changes, so I don't wanna do it rn); that or if this way looks too inconsistent lmk, and we can just do removing the unused stylesheets for this MR and handle moving the CSS in another one. @jamescd18 @anthonybernardi

jamescd18 commented 2 years ago

I see nothing wrong with only have a few components have CSS files, I don't think there's any need to make them be in a separate folder.