Northeastern-Electric-Racing / Shepherd-BMS

Our from-scratch Battery Management Application
4 stars 0 forks source link

Feature/thermsvolts #104

Closed dyldonahue closed 5 months ago

dyldonahue commented 5 months ago

This got more confusing that i hoped, but the goal is to track bad voltage readings and broadcast a percent per segment of bad readings

Check for correctness in the voltage error tracker (segment.c, pull_voltages) and my percentage calculator (analyzer.c, calc_noise_percent)

And, if you think of a better way to architect this (i dont like having the noise_reading and consectuve_noise be seperate params, but wasn't sure a better way to be able to keep noise_reading be reset every reading, while consecutive measure over multilpe readings)

Linking this PR: https://github.com/Northeastern-Electric-Racing/Embedded-Base/pull/130