Closed Sabramz closed 5 months ago
a few things:
fix submodule issues, first jsu ttry updating ur local submodule
i think, just because this is will be hard to test without just seeing the output, it would be cool to maintain the code for the linear extrapolation (current method of calculating SoC). Maybe implement this in parallel so that we can see the result of both, and we can move to this permanently once we are confident it works well
i dont know how this should work well enough so im gonna request some other peeps to keep an eye on this PR too
Changes
Added soc to eeprom. Added eeprom fault to faults table (just in case something goes boom). Edited calc_S_o_C to use coulomb counting.
Notes
My idea for calibration doesn't work. We will either use manual calibration like Nick said, or we find some other way to do it. Also, there is currently no way for the function to get access to a timer that can give it the delta time necessary to coulomb count.
To Do
Any remaining things that need to get done
Checklist
It can be helpful to check the
Checks
andFiles changed
tabs. Please reach out to your Project Lead if anything is unclear. Please request reviewers and ping on slack only after you've gone through this whole checklist.Closes # (issue #)