search

Northeastern-Electric-Racing / Shepherd-BMS

Our from-scratch Battery Management Application
4 stars 0 forks source link

Send all Cell Data over CAN #9

Open dyldonahue opened 1 year ago

dyldonahue commented 1 year ago

Another ticket that was investigated for Shepherd 1.0, but never completed. See the info here (PR), and here (ticket), Mainly, we need to address the issue explained by @mccauleyma in the comments of that ticket, but a lot of the work may already be done in that PR

dyldonahue commented 9 months ago

I’m not going to close this yet, but i dont think this is a really necessary. Not worth the overhead of CAN spam, but open to different opinions

mccauleyma commented 9 months ago

@dyldonahue, if time allows, I'd recommend still matching the Orions ability to do this. The way it was done there was this was an extra setting you could enable during firmware upload and is not recommend for normal day to day use. It's a diagnostic tool for debugging the battery pack. Definitely nice to have if we have time to spare.

dyldonahue commented 9 months ago

That makes sense. If remote over IP works, we would be able to achieve this by just reading serial data remotely, but this shouldn't be hard to do so I will plan to get it done

mccauleyma commented 9 months ago

If you'd prefer that method that works for me. As long as it can be recorded so we can export to MATLAB or whatever we need to analyze

mccauleyma commented 9 months ago

I guess maybe the argument for CAN is being viewable with our telemetry viewing software. But not a big deal. Any situation that we're looking at cell by cell data we are probably looking at a big issue that we need to manually analyze anyways

dyldonahue commented 9 months ago

Ok nah I was off base with what we wanted to do with this, if we wanna export it for longer term control can is best. There will be plenty of time to do this so it should be fine

jr1221 commented 3 months ago

@Sabramz I can take care of this after #108 .