techdebt and styling - Githubissues

Northeastern-Electric-Racing / shepherd_bms

Repo for Shepherd BMS development

5 stars 0 forks source link

techdebt and styling #148

Closed dyldonahue closed 1 year ago

dyldonahue commented 1 year ago

this PR addresses a number of tech debt stuff:

makes CAN msg unions not static
deletes calcs.h and calc.cpp (along with a lil overhead still leftover from that)
uses the macros that already existed for CAN msg IDs in send functions
implement ROS styling (at least bare minimum acceptable levels) to both shepherd and NERduino submodule tbh trying to do NERduino stuff parallelly got fucky so idek if it will show up as part of this or if ill need a PR on NERduino repo as well but im pretty sure I got it to a state that it works so

dyldonahue commented 1 year ago

hey i swear i squashed these commits oops

looks like my submod stuff did some weird things with squashing so im gonna leave it and if everything works out ill just squash when merging