Northeastern-Electric-Racing / shepherd_bms

Repo for Shepherd BMS development
6 stars 0 forks source link

Made function to send cell data CAN msgs #165

Closed HamzaIqbal69 closed 1 year ago

HamzaIqbal69 commented 1 year ago

Issue #158

Added a function to broadcast cell data Goes through each cell and sends a message for each one *Note: the first 4 bits of the message are the chip and the next 4 bits are the cell

Describe your changes

Changes made

-

nwdepatie commented 1 year ago

Also fix merge conflicts pretty pls

dyldonahue commented 1 year ago

well we can control how often this sends, so no reason to think it has to be every cycle. in fact we had pretty much decided that implementation will involve sending less frequently than every iteration.

formatting all looks fine to be but just wanna make sure can ID 0x07 is free and available for this

edit i misunderstood ur point, ur concerned that even if we only send this occasionally just the fact that its a lot at once will be too much. valid and probably just needs to be tested

mccauleyma commented 1 year ago

This is not coded for that type of control though. Right now we could set this to trigger once every x seconds, but when it does trigger it sends all 72 messages back to back. Imo we should replicate Orion and have a counter such that we send the message every x milliseconds and each time it is sent the cell being sent increments. In this case we would need this function to just map 0-71 to what chip and cell it would be

dyldonahue commented 1 year ago

Closing due to concerns pointed out in the comments above. I dont think we ever will really need this data anyway, but if we do, we need to implement some sort of timing control as explained above. Noted for potential reopen at later time