NorthernMan54 / homebridge-tasmota

Plugin for Tasmota devices leveraging Home Assistant auto discovery
Apache License 2.0
35 stars 9 forks source link

LED Light strip support #11

Closed StumbleNOLA closed 3 years ago

StumbleNOLA commented 3 years ago

Is your feature request related to a problem? Please describe: The only problem is that RGB strips aren't supported

Describe the solution you'd like: For LED strips to be supported

Describe alternatives you've considered: N/A

Additional context: I appreciate that the plugin specifically says it doesn't not, as of yet, support RGB strips, I am hoping you would change that. Just for fun I set up a strip with a couple (well 3) MOSFETS and a power supply, and it actually seems to import into HomeKit half way. The lights do show up, and the on/off toggle works fine. But there isn't a way to adjust the color, saturation, or brightness from inside HomeKit.

NorthernMan54 commented 3 years ago

Can you share your Tasmota config for this, and in particular the module type from this screen

Configuration -> Configure Module

And Template if used

For RGB I should not need to grab some hardware this time, just the Tasmota config should do it.

PS These are my RGB lights, just haven't got around to installing Tasmota firmware and working out the config details yet.

https://github.com/NorthernMan54/homebridge-mculed/tree/master/lua

StumbleNOLA commented 3 years ago

Here you go. I just noticed that I may have Tasmota-Sensors.bin installed instead of the normal one. I am happy to confirm this, if you think that may be the issue. Before you go digging into it.

Screen Shot 2020-09-17 at 4 06 15 PM Screen Shot 2020-09-17 at 4 03 37 PM Screen Shot 2020-09-17 at 4 03 55 PM Screen Shot 2020-09-17 at 4 04 53 PM
StumbleNOLA commented 3 years ago

Your schematic is way more complicated than mine (meaning I don't know what many of the parts do). I just have a DC-DC buck converter, a nodeMCU, and three N-channel MOSFET's buried in a case. Oh, and a big spaghetti of wire. I tried to get Fritzing working, but I think their Mac implementation is trash. I couldn't search for parts, and scrolling thru manufacturers one at a time was a joke.

StumbleNOLA commented 3 years ago

I don't mean to be a bother, but is there any movement on this or should I look to another plugin?

NorthernMan54 commented 3 years ago

I’m almost complete with this addition, and should not be much longer. This is taking a bit longer than I thought origninally as I need to write a color space convertor from HomeKit ( hsb ) to Tasmota ( rgb ) and vice versa. In my test setup I have changing color working and am working thru status updates.

No need for parts from amazon this time.

NorthernMan54 commented 3 years ago

If you update to the latest you should now be able to control the colors. I’m not 100% satisfied with the color conversion code, but this should work.

StumbleNOLA commented 3 years ago

Thank you for getting it up and running. I am not qualified to talk about color fidelity, but then I am using cheap strips off of Amazon so meh. But it seems to be working great for me.

NorthernMan54 commented 3 years ago

What I had seen when testing was a little bit of an argument between my code and Tasmota. Looked like this

HomeKit change color to X, convert homekit (HSB) X to (RGB) Y Tasmota ok change color to Y Tasmota send status update color is now Y Plugin convert Y (RGB) to X (HSB) and update Homekit Oh color has changed, tell Tasmota to change color again

Flipping between Homekit (HSB) to Tasmota (RGB) and back isn't 100 reversible with a couple of color selections. Small issue but bothersome, need to look at further.

StumbleNOLA commented 3 years ago

Working as expected. I have no comment on color correctness. Since I am colorblind, but pure colors seem to be fine.

TimVerheul commented 2 years ago

@NorthernMan54 I recently installed your plugin and the state is updating like it should, but I cannot change colors in my RGB strip. only turn the bulb on and dim it.

I tried turning on Debug mode for the plugin and when I change the color of my leds manually then homebridge notice a change in the color but there is no possibility to change colors in homekit.

I used mqttthings before but I wasn't really satisfied with the results, since the state wasn't updating when I changed my colors with my IR remote

TimVerheul commented 2 years ago

image

TimVerheul commented 2 years ago

Also not sure what image this does. I only see in homebridge accessoires that it created this: image but that one isn't visable in homekit

NorthernMan54 commented 2 years ago

Please share your devices tasmota config, I will try recreating it in my setup.

TimVerheul commented 2 years ago

Please share your devices tasmota config, I will try recreating it in my setup.

image you mean this one?

TimVerheul commented 2 years ago

image When I changed the name of my led strip in Tasmota to something else (so i know which led strip im controlling) and I restarted the plugin i got this message about "Configured Name"

Might be useful

TimVerheul commented 2 years ago

@NorthernMan54 I think I found something: the tasmotaLightService.ts on line 67 searches for rgb_cmd_t My config doesn't have rgb_cmd_t, but has hs_cmd_t (HSBColor)

The code is looking for rgb_cmd_t the whole time, so that might be the reason it thinks this is a "normal" lightbulb

NorthernMan54 commented 2 years ago

The more recent versions of tasmota changed the discovery object, your going to need to downgrade to an older tasmota version. Some from before July 2021, or wait until I can code up a fix

Tks for finding this.

https://github.com/arendst/Tasmota/commit/c3d757ca951d8f9ca21d5ae326f553ce4057cd98

TimVerheul commented 2 years ago

It is safe to downgrade Tasmota?

Do you think it cost alot of time to implement the support for the current tasmota version?

NorthernMan54 commented 2 years ago

I added a new issue to track this, #43, pls continue the discussion there