search

NorthernMan54 / homebridge-tasmota

Plugin for Tasmota devices leveraging Home Assistant auto discovery
Apache License 2.0
35 stars 9 forks source link

Feature CO2 and AirQuaility #15

Closed jeroenvermeulen closed 3 years ago

jeroenvermeulen commented 3 years ago

Hi @NorthernMan54, The minute you merged my PR, I did finish my new implementation :-) I think this way is better, I add the missing Device Class in the normalizeMessage() function based on the uniq_id value instead of the icon. This is more reliable and future proof: When the MQTT message contains a Device Class, it will continue working based on the dev_cla field.

jeroenvermeulen commented 3 years ago

So my suggestion is to revert the merge of PR13 and merge this one.

NorthernMan54 commented 3 years ago

This looks better, thanks

NorthernMan54 commented 3 years ago

I have published my full beta to production, fingers crossed. I had been running it for a few days and it was working well. So should be good. I also gave you credit for the addition, Tks

jeroenvermeulen commented 3 years ago

Thank you! I have already installed 0.0.32 on my Synology!

NorthernMan54 commented 3 years ago

I was looking at the auto discovery SPEC for home assistant, and they don't list CO2 as a sensor type ;-(

https://www.home-assistant.io/integrations/sensor/

jeroenvermeulen commented 3 years ago

Apple does support it, so maybe we need to create a PR for Home Assistant. https://developer.apple.com/documentation/homekit/hmcharacteristic/characteristic_types But here in Belgium it is time to go to bed, almost 1:00 AM

NorthernMan54 commented 3 years ago

Tks, again