NorthernMan54
commented
1 year ago Pls keep in mind that HomeKit has an optional hierarchical naming structure, where in this particular context, this.name is the service name, and context.name is the accessory name.
What the code is doing, is checking if the service is named, and if it is using that as the name, if not defaults to the accessory name.
I tried your recommendation
else if (context.name != null && context.name.trim() != "" && !context.name.includes(this.name)) {
// Since we have two names, let them stand
fullName = context.name;And in my setup it broke all my devices with hierarchical naming
So am recommending that this be implemented for your issue
else if (context.manufacturer === "Mitsubishi" && !fullName.includes(this.name)) {
fullName = context.name + " - " + this.name;
jeffgregx2
bakman2
Hi,
I've been trying to use the homebridge-automation plugin to access devices created by a second plugin - homebridge-kumo (Mitsubishi Kumo Cloud devices - i.e., Heating/Cooling devices). This is essentially the same problem reported by #30 .
As part of #30, support for Nest was added with the following changes in Service.js:
A simple workaround to fix this issue is as follows:
however I'm not sure I totally understand why the else clause is arranged the way it is. I would like to propose a "fix" as follows which attempts to preserve context.name if different from this.name and only do the final else clause as a final gasp. Perhaps I'm missing something though.
In my testing this seems to result in the desired output:
Thanks, -Jeff