Communicates between Arduino-programmed AVR and Maxim DS3231 RTC: splice of Ayars' (http://hacks.ayars.org/2011/04/ds3231-real-time-clock.html) and Jeelabs/Ladyada's (https://github.com/adafruit/RTClib) libraries
Current the OSF flag is reset in setSeconds() and no other function is provided to do it. This seems like a bit of an arbitrary choice and has led to some unpredictable errors occurring for me where this flag was being reset without me knowing how. The documentation says it makes good housekeeping sense and perhaps that's true but surely that should the user should at least be given the choice?
I propose that:
Clear OSF flag functionality should be removed from setSeconds().
Clear OSF flag function be defined independently to perform this role.
Current the OSF flag is reset in
setSeconds()and no other function is provided to do it. This seems like a bit of an arbitrary choice and has led to some unpredictable errors occurring for me where this flag was being reset without me knowing how. The documentation says it makes good housekeeping sense and perhaps that's true but surely that should the user should at least be given the choice?I propose that:
setSeconds().