search

NorthwoodsSoftware / GoJS

JavaScript diagramming library for interactive flowcharts, org charts, design tools, planning tools, visual languages.
http://gojs.net
Other
7.7k stars 2.86k forks source link

DimensioningLink extension not binding points #161

Closed MrAbdelaziz closed 2 years ago

MrAbdelaziz commented 2 years ago

Hi,

I found a bug in the DimensioningLink extension, when you use it with binding points to save the current position after (reshapable edits ),

$(DimensioningLink,{reshapable: true,resegmentable:true}, new go.Binding("fromSpot", "fromSpot", go.Spot.parse), new go.Binding("toSpot", "toSpot", go.Spot.parse), new go.Binding("direction"), new go.Binding("extension"), new go.Binding("inset"), now if I remove or add a new link with ( committing transitions ), I lose the positions of links

MrAbdelaziz commented 2 years ago

the solution I found is adding curve: go.Link.Link, adjusting: go.Link.Stretch, I hope that helps someone else :)

WalterNorthwoods commented 2 years ago

That seems to be a bug in the DimensioningLink extension. Try removing the call to updateTargetBindings() in the computePoints method. I don't know why that call is there.