search

NorthwoodsSoftware / GoJS

JavaScript diagramming library for interactive flowcharts, org charts, design tools, planning tools, visual languages.
http://gojs.net
Other
7.8k stars 2.86k forks source link

refactor: replace deprecated String.prototype.substr() #172

Closed CommanderRoot closed 2 years ago

CommanderRoot commented 2 years ago

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated. .substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

WalterNorthwoods commented 2 years ago

Thank you for doing this work. However, we should not accept the changes to libraries that are not ours.