NorthwoodsSoftware / gojs-angular

A set of Angular components to manage GoJS Diagrams, Palettes, and Overviews
Other
61 stars 16 forks source link

DataSyncService not getting custom linkKeyProperty or nodeCategoryProperty #9

Closed cdelgadob closed 4 years ago

cdelgadob commented 4 years ago

When using the data sync service, if the nodeCategoryProperty is set to a custom field or if the linkKeyProperty is set to a value other than 'key', the sync does not work.

The lines responsible of this behaviour are:

https://github.com/NorthwoodsSoftware/gojs-angular/blob/cc96cd903129b83052912edaa400d49dd96f8b58/projects/gojs-angular/src/lib/data-sync.service.ts#L77

https://github.com/NorthwoodsSoftware/gojs-angular/blob/cc96cd903129b83052912edaa400d49dd96f8b58/projects/gojs-angular/src/lib/data-sync.service.ts#L28

rjohnson465 commented 4 years ago

Thank you for bringing this to our attention. I have merged your changes with the master branch