search

NorwegianVeterinaryInstitute / laksetap

App for reporting salmon and rainbow trout losses in Norway
0 stars 0 forks source link

Add the "All" bar for fylke for cohorts plot #27

Closed novica closed 6 months ago

novica commented 6 months ago

@oliveiravhs this for me right now is 'wontfix'

The "all" bar comes from the dataset where you have the same data duplicated twice, as in area "Norge" for viz "all" and area "All" for viz "zone.

so we either have to add another set of duplicated rows as area "All" for viz "fylke" or to do a lot of changes in the app to deal with this. I can add the rows to the dataset as a temporary solution but i think it is a bad idea.

your call.

oliveiravhs commented 6 months ago

I see. I could work later in the update of the dataset to be a proper fix. Would that be an option and keep the temporary for the close release?

novica commented 6 months ago

OK.

novica commented 6 months ago

fixed in https://github.com/NorwegianVeterinaryInstitute/fish_mortality_pins/commit/d7a0b87e721e2ccf21df56b8f040bbfd4e025cdc