NorwoodAndBrixtonFoodbank / nbf-website

https://main.d3dkw68f839t0q.amplifyapp.com/
5 stars 2 forks source link

#206: default parcel page sorting #371

Closed kaydentsoftwire closed 2 months ago

kaydentsoftwire commented 4 months ago

What's changed

Added secondary sorting to sort methods in this order: packing date > packing slot > deliveries then collections > collection centre name > postcode

(if one of these is the primary sort then this is moved to the top).

For each column:

The final sort for all columns is parcel id to ensure consistency

Screenshots / Videos

Before After
image image
image image
image image
image image
image image
image image
image image
image image

Checklist

AmeliaIsCoding commented 4 months ago

Hi @kaydentsoftwire - just checking that you've merged with dev recently, as in my recent ticket I included sorting by "client_is_active" before sorting by any client information fields - this is required because if a client is inactive but has personal information (i.e., a seeded inactive client), we could expose the sensitive information by sorting. This should be included in these sorts now please :)

client information fields are anything in the backend clients table (eg postcode)

stonelink commented 3 months ago

The defaultParcelsSortConfig and changes are to fix the dividing lines behaviour - see this comment: https://github.com/NorwoodAndBrixtonFoodbank/nbf-website/issues/152#issuecomment-2154830486