Closed kaydentsoftwire closed 2 months ago
Hi @kaydentsoftwire - just checking that you've merged with dev recently, as in my recent ticket I included sorting by "client_is_active" before sorting by any client information fields - this is required because if a client is inactive but has personal information (i.e., a seeded inactive client), we could expose the sensitive information by sorting. This should be included in these sorts now please :)
client information fields are anything in the backend clients table (eg postcode)
The defaultParcelsSortConfig
and changes are to fix the dividing lines behaviour - see this comment: https://github.com/NorwoodAndBrixtonFoodbank/nbf-website/issues/152#issuecomment-2154830486
What's changed
Added secondary sorting to sort methods in this order: packing date > packing slot > deliveries then collections > collection centre name > postcode
(if one of these is the primary sort then this is moved to the top).
For each column:
The final sort for all columns is parcel id to ensure consistency
Screenshots / Videos
Checklist
npm run dev
npm run build
andnpm run start
npm run lint_fix
npm run test:e2e