NorwoodAndBrixtonFoodbank / nbf-website

https://main.d3dkw68f839t0q.amplifyapp.com/
5 stars 2 forks source link

Validate user passwords for basic complexity #463

Closed dan-langridge closed 1 week ago

dan-langridge commented 3 months ago

Is your feature request related to a problem? If so, please describe.

When I reset my password as a new user, the only validation is min 6 chars - but there should be a little more checking given it's a publicly-facing system with sensitive personal information

Describe the solution / feature you'd like

Some basic complexity rules in place for new or reset passwords. Prevent user assigning 'password' or '123123' etc.

Additional context

I don't personally believe that forcing users to design complex passwords necessarily makes things more secure, but zero checks just isn't consistent with the GDPR security principle in the longer term, given any user can in effect download a full client list via Parcels page

rjesson-softwire commented 2 months ago

QA instructions: Passwords on the website should not be accepted unless they are over 8 characters and contain at least one uppercase, lowercase, numeric, and special character. Check that these restrictions are applied in all places:

make sure all ways of submitting the various forms only accept passwords of the above form, e.g pressing the button, pressing enter, etc

SoftJoelWire commented 2 months ago

QAed all except enter button (hotfix pending)

dan-langridge commented 1 week ago

Happy that this is complete