Nosferican / Econometrics.jl

Econometrics in Julia
https://nosferican.github.io/Econometrics.jl/dev
ISC License
69 stars 19 forks source link

Update dependencies and make them more flexible #24

Closed bkamins closed 4 years ago

bkamins commented 4 years ago

Hi - I am starting a course where I want to use this nice package. The problem I have is that it has conflicting dependencies with some other packages I use.

I am not sure about your compatibility policy, so I in this PR I just propose to change the versions of all packages to their latest (hopefully the tests will pass πŸ˜„).

As a more extreme proposal maybe you can consider making >= dependencies for some packages so that you do not need to track the dependencies that often and update your package (this is less safe, but more convenient so there is a trade-off here).

codecov[bot] commented 4 years ago

Codecov Report

Merging #24 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   90.03%   90.03%           
=======================================
  Files           8        8           
  Lines         622      622           
=======================================
  Hits          560      560           
  Misses         62       62

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 76a6962...9f6a332. Read the comment docs.

Nosferican commented 4 years ago

Hi @bkamins. Glad to hear the package is being useful (do stargaze it :smile:) and πŸ₯‡ on being the first to submit a PR. I usually try to follow semver which in an ideal world should work quite well. I see the new releases are FillArrays, StatsBase, and Optim (I try to keep up-to-date with compat breaking releases, but maybe someone will dev the GitHub Actions to auto check those). Thanks!

bkamins commented 4 years ago

Can we tag it?

Nosferican commented 4 years ago

Aye. I am working on a quick fix to the docs and will tag it. It should be available soon after the General purge cool down period (General frozen for a day to test the purge of non Julia v1 compat versions).