search

Nosmoht / ansible-module-foreman

Ansible module to manage configuration of Foreman
49 stars 32 forks source link

Add parameter to disable SSL #29

Closed stintel closed 8 years ago

Nosmoht commented 8 years ago

Hi Sintel,

thanks for your request. Could you please change the default to False? Otherwise all other users are forced to add this parameter to there plays if they don't use SSL.

Thanks

stintel commented 8 years ago

@Nosmoht before https://github.com/Nosmoht/python-foreman/commit/cac2c417e311dc107eadc46eb75e227175c0faeb the URL scheme was hardcoded to https, so afaik it wasn't even possible to use these modules on a Foreman setup without SSL. For this very reason I set it enabled by default, so everyone else using it doesn't need to change anything. Is there something I am missing?

Nosmoht commented 8 years ago

Hi stintel, thanks for your comment. Seems that i misunderstood you. Sorry.

stintel commented 8 years ago

@Nosmoht np and thanks for the merge!