search

Nosmoht / ansible-module-foreman

Ansible module to manage configuration of Foreman
49 stars 32 forks source link

host: also check for power state on and off #40

Closed stintel closed 8 years ago

stintel commented 8 years ago

The return values for the power_action "state" come from the BMC or hypervisor Foreman makes the calls to, so they aren't unified.

On vSphere the return values seem to be on and off, so check the power state against these values as well.

Nosmoht commented 8 years ago

Strange that the Foreman provider interface does not unify that. Especially as i developed the module using VMware ESX 5.5 as Foreman backend.

stintel commented 8 years ago

FYI, this is from #theforeman on Freenode:

12|13:28:11 < stintel> hmmm, where are the possible return values defined for API v2 host power_action = state ?
12|13:29:24 < stintel> it's returning on, and some code I am using expects poweredOn. just wonder where I can find it, so that I can link to it in my PR to fix that code
12|13:31:09 < dLobatog> stintel: the returned values come from the BMC or the hypervisor Foreman make the calls to, so they can be anything, we don't have control over them
12|13:31:22 < dLobatog> there was a pull request that tried  to unify them but it ended up being a lot of work
12|13:31:44 < stintel> dLobatog: I see, that explains why I can't find it :)