search

Nosmoht / ansible-module-foreman

Ansible module to manage configuration of Foreman
49 stars 32 forks source link

Add to ansible-modules-extras #49

Open ehelms opened 7 years ago

ehelms commented 7 years ago

Howdy,

I was recently made aware of your Ansible module for managing Foreman resources. Also recently, I had gotten a starter module space added to ansible-modules-extras official repository so as to have Foreman and Katello support available by default in future releases [1]. Would you be interested in collaborating to have the contents of this repository added to the set available functionality for the Foreman set of modules and entities?

[1] https://github.com/ansible/ansible-modules-extras/tree/devel/infrastructure/foreman

Nosmoht commented 7 years ago

Hi @ehelms,

happy to collaborate. I've already started to adapt the modules to pass the sanity checks of Ansible modules but have some problems using the ansible_module.utils.urls.fetch_url() method. As soon as i've fixed it we can see how to bring both together.

BTW: Your code is using nailgun which requires requests. What i've learned from my IPA modules (https://github.com/ansible/ansible-modules-extras/pull/3247) is that Ansible modules are checked against Python 2.4 which, as far as i know, does not have Python requests. That's why i had to replace requests with fetch_url() from ansible_module.utils.urls. It might be that you come to the same issue ;)