Nossiac / mtk-openwrt-feeds

mtk-openwrt-feeds
428 stars 204 forks source link

drivers for mt7613 #127

Open bricco1981 opened 1 year ago

bricco1981 commented 1 year ago

hi, thanks a lot for your help with this drivers. I'm try to understand how get drivers for mt7613be chipset, I cannot find any info. I'm talking about mtk and not mt76.should this card work with mt7615 drivers?

bricco1981 commented 2 months ago

my good

ravichaudhary133 commented 2 months ago

Man, i am stuck now, could flash with TFTP, the device isnt detecting lan port to receive file from tftp server. And u-boot shows crc error.

bricco1981 commented 2 months ago

please help a bit sent the right files to change that.

ravichaudhary133 commented 2 months ago

the change needs to be done in /include/ directory and image-commands.mk needs to be edited. 0x4 needs to be replaced by 0x10000 for tplinkv2 configuration

ravichaudhary133 commented 2 months ago

@bricco1981 sorry for the trouble, the device is up and running again, found out that the ethernet port of my laptop is faulty. Would request a build if possible!

bricco1981 commented 2 months ago

hi, please wait, untill tomorrow, i'm not on my main pc, i'll make a build for you, but please share the changes, i cannot look at DTS device too.

ravichaudhary133 commented 2 months ago

As i have mentioned it earlier that a small change needs to made in the "include/image-commands.mk" file. It is shown in the following video too https://youtu.be/sjkU99-2onA?t=2m56s.

vikingloudmouth commented 2 months ago

@vikingloudmouth please can you test this, @ravichaudhary133 looks sloow! openwrt-ramips-mt7621-tplink_archer-a6-v3-squashfs-sysupgrade.zip

No offence, but I'd rather test from some source code. I'll wait until you publish the driver. If you would like me to test before that, just upload a zip of your current version and I'll build from that.

ravichaudhary133 commented 2 months ago

@bricco1981 waiting for your test build!

bricco1981 commented 2 months ago

@vikingloudmouth for respect reason i'm using your drivers, because you did that before me. change your first makefile depends like this. mt_wifi.zip

DEPENDS:=@TARGET_ramips delete the folder wifi scripts and delete the folder files. add this mt_wifi you will find it in makemenuconfig under network/wireless. just enable it. @ravichaudhary133 wait i just wakeup.

ravichaudhary133 commented 2 months ago

Alright! Thank you for your efforts

bricco1981 commented 2 months ago

@ravichaudhary133 so i changed yhis and add luci proto qmi is that all?

in include/image-commands.mk from:

                -T $(TPLINK_HVERSION) -V "ver. 2.0" -a 0x4 -j \

to:

                -T $(TPLINK_HVERSION) -V "ver. 2.0" -a 0x10000 -j \
ravichaudhary133 commented 2 months ago

Yupp, that is all what was needed, let me try the build. Thank you!

ravichaudhary133 commented 2 months ago

I really dont know which source code you are using but the Image check while upgrading always fails saying metadata not available and "The uploaded image file does not contain a supported format. Make sure that you choose the generic image format for your platform."

And ends up in bootloop after forced flash!

bricco1981 commented 2 months ago

i do not know why, but i think it's only with this device. you can use serial to see what's going on.

ravichaudhary133 commented 2 months ago

Boot stops after flashing bad magic error on serial console.

Btw, is using the mt_wifi.zip and luci-app-mtwifi.zip sufficient to get it working?!

I think i should myself give it a try.

bricco1981 commented 2 months ago

yes make the changes as i said to @vikingloudmouth drivers, and add luci mtwifi and mt_wifi. let me know if it will boot.if it does not boot could be the e2p bin the problem, just test.

ravichaudhary133 commented 2 months ago

Alright @bricco1981 which openwrt version should i use?!

bricco1981 commented 2 months ago

23.05.3

ravichaudhary133 commented 2 months ago

Have you added some extra bin ?! Couldnt get what e2p.bin is!

bricco1981 commented 2 months ago

is the eprom.bin, is in mt_wifi folder is called e2p if your device do not boot rename it like e2px and build again

do this from luci download your radio partition, rename it e2p, and put it in mt_wifi folder.

that's what we need test now, if we can use that bin as universal.

ravichaudhary133 commented 2 months ago

@vikingloudmouth for respect reason i'm using your drivers, because you did that before me. change your first makefile depends like this. mt_wifi.zip

DEPENDS:=@TARGET_ramips delete the folder wifi scripts and delete the folder files. add this mt_wifi you will find it in makemenuconfig under network/wireless. just enable it. @ravichaudhary133 wait i just wakeup.

Could you please elaborate, in which makefile do i have to make changes and what exactly?! Sorry if i am sounding noob!

bricco1981 commented 2 months ago

in the first makefile of driver,set olnly this as depend define Package/mt_wifi SECTION:=net CATEGORY:=Network TITLE:=MTK wifi AP config DEPENDS:=@TARGET_ramips +wireless-tools SUBMENU:=Wireless endef

sorry it was confusing that. the folder mt_wifi i shared is for data profile, inside the only thing that maybe you need change is e2p. stop. now you need edit the makefile of mt7663 drivers.

ravichaudhary133 commented 2 months ago

@bricco1981 man, really sorry but i think i am finding myself completely noob at placing the downloaded files in destined locations.

I have cloned and updated and installed the feeds in my pc. But couldnt go ahead with placing the luci-app-mtkwifi and mt_wifi folders. I think i forgot everything of earlier when i compiled for mt7603 around 06 minths back.

Any guidance will be highly appreciated.

ravichaudhary133 commented 2 months ago

Where should i place the folders man?!

openwrt/target/linux/ramips ? Or openwrt/package/kernel ?!

bricco1981 commented 2 months ago

that's not important create a folder package/mt inside mt7603 driver mt7663 driver luci app mtwifi and mt_wifi.

ravichaudhary133 commented 2 months ago

So, i am following the instructions from https://github.com/Azexios/openwrt-r3p-mtk and after that will replace the mt_wifi folder in /openwrt/package/mt/drivers !

Is it right to do so?

bricco1981 commented 2 months ago

yes you right reploace luci app too with mine.note that Azexios mt7603 drivers will not compile on 5.15.x kernel

ravichaudhary133 commented 2 months ago

Which drivers did you use for mt7603 man?!

bricco1981 commented 2 months ago

you want drive me crazy. mt7603e.zip

ravichaudhary133 commented 2 months ago

Really sorry for the annoyance man! Thanks a ton!

bricco1981 commented 2 months ago

@ravichaudhary133 well for now i'm not sure if that is important, but i fixed wpa3 in luci.

ravichaudhary133 commented 2 months ago

in the first makefile of driver,set olnly this as depend define Package/mt_wifi SECTION:=net CATEGORY:=Network TITLE:=MTK wifi AP config DEPENDS:=@TARGET_ramips +wireless-tools SUBMENU:=Wireless endef

sorry it was confusing that. the folder mt_wifi i shared is for data profile, inside the only thing that maybe you need change is e2p. stop. now you need edit the makefile of mt7663 drivers.

Man, this might be the last query!

Do i have to make changes in the Makefile in the mt_wifi.zip which you provided?!

Otherwise i couldnt find any Makefile in the /openwrt/package/mt/drivers directory.

bricco1981 commented 2 months ago

no you do not need change the makefile of mt_wifi folder that i shared. you need change the makefile of mt7663 drivers , only two files are present makefile and config.in delete folder wifi scrips and folder files, all in mt7663 drivers.

bricco1981 commented 2 months ago

use this all update, @vikingloudmouth new complete folder. mt-drivers.zip

the thing that we need make sure is if e2p can be used on all devices, that's the point now.

ravichaudhary133 commented 2 months ago

@bricco1981 do i have to disable hostapd-common in the menuconfig?

As mentioned in a different thread- In Network > Wireless - set the settings in mt_wifi from point 2. In Network > WirelessAPD - disable wpad-basic-wolfssl and select hostapd-common as a module.

bricco1981 commented 2 months ago

yes disable you will save space.you do not set as module, disable wpad and hostapd

ravichaudhary133 commented 2 months ago

I couldnt disable hostapd-common in the menuconfig, the options cannot be modified.

bricco1981 commented 2 months ago

because you have enableb mt76 drivers or wpad or mac8011

ravichaudhary133 commented 2 months ago

Alright, will disable all.

Thanks for all your help man! May i know your telegram username or any other platform for that matter?!

bricco1981 commented 2 months ago

sorry i do not use social or stuff like that. as i said now we need understand if we can use e2p on all devices.

ravichaudhary133 commented 2 months ago

Alright, will let you know if i can boot it in my device once the build is complete

ravichaudhary133 commented 2 months ago

use this all update, @vikingloudmouth new complete folder. mt-drivers.zip

the thing that we need make sure is if e2p can be used on all devices, that's the point now.

Man, i used this zip and used v23.05.3 as source, but mt7603e doesnt compile. The build stops at mt7603e.

bricco1981 commented 2 months ago

before you flash the image, from an openwrt working image from luci download mtdblock partition radio, rename it e2p and have it saved on your pc.

ravichaudhary133 commented 2 months ago

use this all update, @vikingloudmouth new complete folder. mt-drivers.zip the thing that we need make sure is if e2p can be used on all devices, that's the point now.

Man, i used this zip and used v23.05.3 as source, but mt7603e doesnt compile. The build stops at mt7603e.

@bricco1981 can ubuntu version be the reason?! Or should i try a previous kernel source?

bricco1981 commented 2 months ago

i do not know make -j1 V=sc and show the error.

ravichaudhary133 commented 2 months ago
`make -f ./scripts/Makefile.build obj=/home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap \ single-build= \ need-builtin=1 need-modorder=1 ccache mipsel-openwrt-linux-musl-gcc -Wp,-MMD,/home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/ap/.ap.o.d -nostdinc -isystem /home/ubuntu/openwrt/staging_dir/toolchain-mipsel_24kc_gcc-12.3.0_musl/lib/gcc/mipsel-openwrt-linux-musl/12.3.0/include -I./arch/mips/include -I./arch/mips/include/generated -I./include -I./arch/mips/include/uapi -I./arch/mips/include/generated/uapi -I./include/uapi -I./include/generated/uapi -include ./include/linux/compiler-version.h -include ./include/linux/kconfig.h -include ./include/linux/compiler_types.h -DKERNEL -DVMLINUX_LOAD_ADDRESS=0xffffffff80001000 -DLINKER_LOAD_ADDRESS=0x80001000 -DDATAOFFSET=0 -fmacro-prefix-map=./= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu11 -mno-check-zero-division -mabi=32 -G 0 -mno-abicalls -fno-pic -pipe -mno-branch-likely -msoft-float -DGAS_HAS_SET_HARDFLOAT -Wa,-msoft-float -ffreestanding -EL -fno-stack-check -Wa,-mno-fix-loongson3-llsc -march=mips32r2 -mtune=34kc -Wa,--trap -DTOOLCHAIN_SUPPORTS_VIRT -DTOOLCHAIN_SUPPORTS_XPA -DTOOLCHAIN_SUPPORTS_CRC -DTOOLCHAIN_SUPPORTS_DSP -DTOOLCHAIN_SUPPORTS_GINV -I./arch/mips/include/asm/mach-ralink -I./arch/mips/include/asm/mach-ralink/mt7621 -I./arch/mips/include/asm/mach-generic -fno-asynchronous-unwind-tables -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=1024 -fstack-protector -Werror -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -Wno-dangling-pointer -fomit-frame-pointer -fno-stack-clash-protection -g -fno-var-tracking -femit-struct-debug-baseonly -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wno-stringop-truncation -Wno-zero-length-bounds -Wno-array-bounds -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -I/home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/include -I/home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/ate/include -DMT7603 -DMT_BBP -DMT_RF -DRTMP_RF_RW_SUPPORT -DMT_MAC -DRTMP_MAC_PCI -DRTMP_PCI_SUPPORT -DMCS_LUT_SUPPORT -DRELEASE_EXCLUDE -DMT_RF -DRTMP_RF_RW_SUPPORT -DRTMP_PCI_SUPPORT -DRX_DMA_SCATTER -DCONFIG_ANDES_SUPPORT -DRTMP_EFUSE_SUPPORT -DA_BAND_SUPPORT -DNEW_MBSSID_MODE -DENHANCE_NEW_MBSSID_MODE -DRESOURCE_PRE_ALLOC -DRTMP_EFUSE_SUPPORT -DCONFIG_FPGA_MODE -DDATA_QUEUE_RESERVE -DMULTI_CLIENT_SUPPORT -DSMART_CARRIER_SENSE_SUPPORT -DLIMIT_GLOBAL_SW_QUEUE -DNEW_RATE_ADAPT_SUPPORT -DRTMP_MAC_PCI -DRTMP_PCI_SUPPORT -DUAPSD_SUPPORT -DUAPSD_DEBUG -DMT_PS -DWSC_INCLUDED -DWSC_SINGLE_TRIGGER -DWSC_AP_SUPPORT -DDOT11W_PMF_SUPPORT -DSOFT_ENCRYPT -DAPCLI_DOT11W_PMF_SUPPORT -DMTFWD -DDOT11N_DRAFT3 -DLLTD_SUPPORT -DMBSS_SUPPORT -DAPCLI_SUPPORT -DMAT_SUPPORT -DTRAFFIC_BASED_TXOP -DAPCLI_AUTO_CONNECT_SUPPORT -DMULTI_APCLI_SUPPORT -DMAC_REPEATER_SUPPORT -DCONFIG_ATE -DCONFIG_QA -DCONFIG_RT2880_ATE_CMD_NEW -DRTMP_FLASH_SUPPORT -DMULTI_INF_SUPPORT -DRTMP_EFUSE_SUPPORT -DCAL_FREE_IC_SUPPORT -DCONFIG_RT_FIRST_CARD=y -DCONFIG_RT_FIRST_IF_RF_OFFSET=0 -DCONFIG_RT_FIRST_CARD_EEPROM="\"flash\"" -DCONFIG_FIRST_IF_EPAELNA -DENHANCED_STAT_DISPLAY -DNEW_RATE_ADAPT_SUPPORT -DRELEASE_EXCLUDE -DFIFO_EXT_SUPPORT -DCONFIG_BA_REORDER_MONITOR -DUSE_BMC -DMT_PS -DDMA_RESET_SUPPORT -DTXRXCR_DEBUG_SUPPORT -DMT7603_E1 -DMT7603_E2 -DEDCCA_RB -DLOAD_FW_ONE_TIME -DEAPOL_QUEUE_SUPPORT -DAGGREGATION_SUPPORT -DPIGGYBACK_SUPPORT -DWMM_SUPPORT -DLINUX -Wall -Wstrict-prototypes -Wno-trigraphs -Wframe-larger-than=4096 -DCONFIG_RALINK_FLASH_API -DCONFIG_AP_SUPPORT -DSCAN_SUPPORT -DAP_SCAN_SUPPORT -DDOT11_N_SUPPORT -DSTATS_COUNT_SUPPORT -DIAPP_SUPPORT -DDOT1X_SUPPORT -DDBG -DIP_ASSEMBLY -DACS_CTCC_SUPPORT -DSW_ATF_SUPPORT -DMODULE -mno-long-calls -DKBUILD_BASENAME='"ap"' -DKBUILD_MODNAME='"mt7603e"' -D__KBUILD_MODNAME=kmod_mt7603e -c -o /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/ap/ap.o /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/ap/ap.c In file included from /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/include/rtmp_os.h:46, from /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/include/rtmp_comm.h:82, from /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/include/rt_config.h:35, from /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/ap/ap.c:29: /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/include/os/rt_linux.h:886: error: "DMA_MAPPING_ERROR" redefined [-Werror] 886 #define DMA_MAPPING_ERROR(_handle, _ptr) \
In file included from ./include/linux/pci-dma-compat.h:8, from ./include/linux/pci.h:2456, from /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/include/os/rt_linux.h:28: ./include/linux/dma-mapping.h:74: note: this is the location of the previous definition 74 #define DMA_MAPPING_ERROR (~(dma_addr_t)0)

/home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/ap/ap.c: In function 'MacTableMaintenance': /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/include/os/rt_linux.h:395:5: error: this 'if' clause does not guard... [-Werror=misleading-indentation] 395 | if (__irqflags); \ | ^~ /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/include/os/rt_linux_cmm.h:218:73: note: in expansion of macro 'OS_IRQ_LOCK' 218 | #define RTMP_IRQ_LOCK OS_IRQ_LOCK | ^~~ /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/ap/ap.c:2859:9: note: in expansion of macro 'RTMP_IRQ_LOCK' 2859 | RTMP_IRQ_LOCK(&pAd->irq_lock, IrqFlags); | ^~~~~ /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/ap/ap.c:2859:39: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 2859 | RTMP_IRQ_LOCK(&pAd->irq_lock, IrqFlags); | ^~~~ /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/include/os/rt_linux.h:396:9: note: in definition of macro 'OS_IRQ_LOCK' 396 | __irqflags = 0; \ | ^~~~~~ /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/ap/ap.c:2859:9: note: in expansion of macro 'RTMP_IRQ_LOCK' 2859 | RTMP_IRQ_LOCK(&pAd->irq_lock, IrqFlags); | ^~~~~ /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/ap/ap.c: In function 'DOT1X_InternalCmdAction': /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/ap/ap.c:3834:9: error: ISO C90 forbids variable length array 'FrameBuf' [-Werror=vla] 3834 | UCHAR FrameBuf[frame_len]; | ^~~~~ /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/ap/ap.c: In function 'DOT1X_EapTriggerAction': /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/ap/ap.c:3895:9: error: ISO C90 forbids variable length array 'FrameBuf' [-Werror=vla] 3895 | UCHAR FrameBuf[frame_len+32]; | ^~~~~ cc1: all warnings being treated as errors make[5]: [scripts/Makefile.build:289: /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap/../mt7603_wifi/ap/ap.o] Error 1 make[4]: [Makefile:1908: /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/mt7603_wifi_ap] Error 2 make[4]: Leaving directory '/home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/linux-5.15.150' make[3]: [Makefile:65: /home/ubuntu/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/mt7603_wifi/.built] Error 2 make[3]: Leaving directory '/home/ubuntu/openwrt/package/mt-drivers/mt7603e' time: package/mt-drivers/mt7603e/compile#2.80#0.24#2.99 ERROR: package/mt-drivers/mt7603e failed to build. make[2]: [package/Makefile:129: package/mt-drivers/mt7603e/compile] Error 1 make[2]: Leaving directory '/home/ubuntu/openwrt' make[1]: [package/Makefile:123: /home/ubuntu/openwrt/staging_dir/target-mipsel_24kc_musl/stamp/.package_compile] Error 2 make[1]: Leaving directory '/home/ubuntu/openwrt' make: [/home/ubuntu/openwrt/include/toplevel.mk:232: world] Error 2 `

bricco1981 commented 2 months ago

make sure you have set this CONFIG_WIRELESS_EXT=y CONFIG_WEXT_CORE=y CONFIG_WEXT_PRIV=y CONFIG_WEXT_PROC=y CONFIG_WEXT_SPY=y

CONFIG_KERNEL_WERROR is not set

ravichaudhary133 commented 2 months ago

Even after adding-

CONFIG_WIRELESS_EXT=y CONFIG_WEXT_CORE=y CONFIG_WEXT_PRIV=y CONFIG_WEXT_PROC=y CONFIG_WEXT_SPY=y

the error remains the same.

bricco1981 commented 2 months ago

config_kernel_werror is not set