Category Personalization - Ignore product ids if they are not numeric - Githubissues

Nosto / nosto-magento

Magento extension for Nosto

https://marketplace.magento.com/nosto-nosto-tagging.html

Open Software License 3.0

27 stars 24 forks source link

Category Personalization - Ignore product ids if they are not numeric #519

Closed supercid closed 5 years ago

supercid commented 5 years ago

Description

If Category Personalization GraphQL calls return products with non-numeric id's, they are no longer used for sorting.

Related Issue

Closes #515

Motivation and Context

The sorting could crash if non-numeric product ids were used.

How Has This Been Tested?

Tested with preview mode enabled and mock products id's such as nostomp1.
Tested with hardcoded non-numerical id's.

Documentation:

N/A

Checklist:

[x] My code follows the code style of this project.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] I have assigned the correct milestone or created one if non existent.
[x] I have correctly labeled this pull request.
[x] I have linked the corresponding issue in this description.
[x] I have updated the corresponding Jira ticket.
[x] I have requested a review from at least 2 reviewers
[x] I have checked the base branch of this pull request
[x] I have checked my code for any possible security vulnerabilities