Remove String typehint in URL helper - Githubissues

Nosto / nosto-magento

Magento extension for Nosto

https://marketplace.magento.com/nosto-nosto-tagging.html

Open Software License 3.0

27 stars 24 forks source link

Remove String typehint in URL helper #534

Closed supercid closed 5 years ago

supercid commented 5 years ago

Description

Remove wrongful method parameter type which is incompatible with PHP < 5.6

Related Issue

Closes #528

How Has This Been Tested?

Checklist:

[X] My code follows the code style of this project.
[X] I have updated the documentation accordingly.
[X] All new and existing tests passed.
[X] I have assigned the correct milestone or created one if non existent.
[X] I have correctly labeled this pull request.
[X] I have linked the corresponding issue in this description.
[X] I have updated the corresponding Jira ticket.
[X] I have requested a review from at least 2 reviewers
[X] I have checked the base branch of this pull request
[X] I have checked my code for any possible security vulnerabilities