Nosto / nosto-magento2

https://marketplace.magento.com/nosto-module-nostotagging.html
Open Software License 3.0
27 stars 26 forks source link

Improvements for after events: add magento objects #85

Closed vmalyk closed 7 years ago

vmalyk commented 7 years ago

For extending Nosto data need to reload magento object and it can decrease performance on build data. If you add original object to events It`ll provide more clear extending for data. For example, https://github.com/Nosto/nosto-magento2/blob/develop/Model/Product/Builder.php#L197 add: $this->eventManager->dispatch('nosto_product_load_after', ['nostoData' => $nostoProduct, 'product' => $product]);

mridang commented 7 years ago

@vmalyk Good point. We'll do this ASAP.