Nostradongus / AGC-Print

2 stars 1 forks source link

US#6 Email can not be updated #18

Closed JulCL123 closed 3 years ago

JulCL123 commented 3 years ago

Branch : sprint2-with-profile

Summary : Whenever an email is to be edited, it will receive a status of 422. The other inputs are accepted and added as changes to the database. As long as the email field is not empty, the edits will not be accepted.

Steps :

HMoneda commented 3 years ago

Hello, Issue has been fixed, kindly test the changes. Thank you!!!

jason-9601 commented 3 years ago

@HMoneda Hello it works already but you cannot update the contact number or the password alone. In order to update the contact number or password you would have to also update the email. Unless it was intended to be this way where in all fields really have to be updated.

If ever, the issue might be in validator not accepting an empty field as a valid email. Thanks.

HMoneda commented 3 years ago

@jason-9601 Hello! Yup the issue was regarding the server validation, I've now put a validator for the field being optional and pushed the changes. Thank you!

JulCL123 commented 3 years ago

@HMoneda Hello! I'm not sure if you'd consider this as a bug but both contact number and password accept the old contact number and password (e.g. old: "password" new: "password" = accepted). Let us know if this is intended so we can count it as a "pass" in the test script. Thank you!

HMoneda commented 3 years ago

@JulCL123 Hello entering the old contact and password is not intended and should have a corresponding error message as well, I've pushed the recent changes, thank you!!