NotAShelf / nvf

A highly modular, extensible and distro-agnostic Neovim configuration framework for Nix/NixOS.
https://notashelf.github.io/nvf/
MIT License
160 stars 26 forks source link

Pin neovim version #206

Open NotAShelf opened 7 months ago

NotAShelf commented 7 months ago

Currently we're using neovim-unwrapped from nixos-unstable, which may change inbetween nixpkgs input bumps, or for those overriding the nixpkgs input.

I propose that we get the neovim-unwrapped package from the neovim repository directly, using the flake they provide in the contrib directory, allowing us to pin the branch directly as follows:

# ...

inputs.neovim-unwrapped.url = "github:neovim/neovim/v0.9.5?dir=contrib";

# ...

and also allows users to do so at their own peril.

Overriding the package has been made easier already through the help of the customizable package option that I've added recently, but I do like the idea of making the input customizable also.

CC @FrothyMarrow and @horriblename for feedback.

horriblename commented 7 months ago

seems like a good change, no objections.

FrothyMarrow commented 7 months ago

Same here, sounds like a good idea.