search

NotAShelf / nvf

A highly modular, extensible and distro-agnostic Neovim configuration framework for Nix/NixOS.
https://notashelf.github.io/nvf/
MIT License
212 stars 29 forks source link

Fix lua null conversion #226

Closed horriblename closed 8 months ago

horriblename commented 8 months ago

fixes two bugs with null conversions:

  1. expToLua converts null to null (should be nil)
  2. toLuaObject converts null to ""
horriblename commented 8 months ago

I don't think so, it would cause runtime errors as that might result in invalid lua syntax.

in fact I think "" shouldn't be there at all and should just error out

I'll read through the usage to see how its used

horriblename commented 8 months ago

everywhere toLuaObject is used "" is not valid syntax, so I changed it to throw an error