NotAShelf / nvf

A highly modular, extensible and distro-agnostic Neovim configuration framework for Nix/NixOS.
https://notashelf.github.io/nvf/
MIT License
158 stars 26 forks source link

lualine: limit catppuccin reliance; update flake inputs #290

Closed amadalusia closed 4 months ago

amadalusia commented 4 months ago

Why did I make these changes?

Lockfile: Neovim Nightly broke noice.nvim's LSP progress function. This was fixed upstream but it should be updated here too. Catppuccin Reliance: It caused every theme that wasnt catppuccin to break into this ugly mess lmao

Catppuccin overreliance may also exist in other files too but I'll feel compelled enough to check come the weekends.

amadalusia commented 4 months ago

I'll get on it :+1:

NotAShelf commented 4 months ago

Looks good. Glad to finally have this addressed. Just one minor nit:

Please follow the commit format as specified in the documentation. In your case, it should be squashed into three commits.

For lualine module:

lualine: limit catppuccin reliance

For flake.nix:

flake: update inputs

For docs:

docs: update 0.7 release notes
amadalusia commented 4 months ago

ill probably set up another pr because right now im horrible at git lmao

ill try to figure something out without creating 4 new fake commits, it'll look like artificial commit increasing which is something i do not want

amadalusia commented 4 months ago

alright yeah i dont think this is possible, ill make another pr

NotAShelf commented 4 months ago

I would rebase, but looks like flake update and lualine changes have been done in the smae commit.

amadalusia commented 4 months ago

yeah thats gonna be the big thing i cant really do with a rebase, ill try it again and ill make sure to read the commit format rules that time around lmaoo, im so untidy with git

NotAShelf commented 4 months ago

I was meaning to clean up lualine for a while now. I think I'll create a PR myself to address your issues and my own.

NotAShelf commented 4 months ago

Created #291.