Closed diniamo closed 2 months ago
I seem to be getting this error when I evaluate my system config with this branch, no idea what it means.
This builds, and neovim runs without errors, however bufferline still doesn't appear.
sorry for the mess, I rebased this PR onto main, as the other one isn't going anywhere
Oh, I was kinda confused.
Either way I can't seem to figure out why bufferline doesn't work, so..
needs to set showtabline
to 2 I believe
needs to set
showtabline
to 2 I believe
There is an option called auto_toggle_bufferline
, it was incorrectly set to false. It is used to manually enable/disable the bufferline, setting it to true would fix the issue. Also shottabline
should be avoided for this because it is updated internally in nvim-bufferline.
Nope, I found the issue: https://github.com/NotAShelf/nvf/blob/d10b1fc366480f77590b3020d1b136e539277269/modules/plugins/tabline/nvim-bufferline/nvim-bufferline.nix#L26
raaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaf
I'm ready to merge then
Nope, I found the issue:
raaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaf
This wouldn't fix the issue where the bufferline is disabled by default.
What do you mean?
What do you mean?
The bufferline is hidden by default.
That's quite literally the issue it solves?
That's quite literally the issue it solves?
It is an existing issue on the latest commit.
I never had that happen.
bufferline still missing for me
yea auto_toggle_bufferline
fixed it for me
Oh I had that on, because I'd use it anyway. I looked at bufferline's codebase, and I get what it's supposed to do, but they early return on the update function based on that setting, and the same update function is used to show bufferline initially, I guess we default it to true?
Oh I had that on, because I'd use it anyway. I looked at bufferline's codebase, and I get what it's supposed to do, but they early return on the update function based on that setting, and the same update function is used to show bufferline initially, I guess we default it to true?
Please confirm that the defaults match with the ones set by the plugin here.
@FrothyMarrow I'm not so sure about that, I'm pretty sure nvf defines its own defaults for multiple plugins, based on raf's tastes or something.
@FrothyMarrow I'm not so sure about that, I'm pretty sure nvf defines its own defaults for multiple plugins, based on raf's tastes or something.
You're right, It is my preference. If it is just a change in cosmetics, I don't mind changing them. For a new user, it is easier to work with the defaults provided by the plugin, and it is easier for us to debug the config when something breaks. I don't think @NotAShelf has a particular distaste for either of these approaches from my past contributions.
One example where these problems become apparent is when a user wants to have the defaults set by the plugin. Since we have removed the option to filter out null options, the user is no longer able to easily remove the default config set by nvf. They have to dig through the source code to figure out what the expected default is.
That should be all of them, I recommend double checking since my eyes could have slipped very easily.
Note: nvim starts without errors but bufferline doesn't appear.