NotAShelf / nvf

A highly modular, extensible and distro-agnostic Neovim configuration framework for Nix/NixOS.
https://notashelf.github.io/nvf/
MIT License
155 stars 24 forks source link

treewide: refactor custom lib, merge lists in hm/nixos module #323

Closed diniamo closed 2 months ago

diniamo commented 2 months ago

Fixes #328

NotAShelf commented 2 months ago

I'll need @FrothyMarrow and @horriblename to also provide their reviews, specifically on the addition of anythingConcatLists.

diniamo commented 2 months ago

everything LGTM, but I am quite unsure about the addition of anythingConcatLists.

I don't see a better way to fix #328 without heavy refactoring.

NotAShelf commented 2 months ago

Again, I am not particularly against it (and testing yields okay results) but I'd like second and third opinions before I merge it.