Colorizer not attaching to buffers

Jappie3 commented 4 hours ago

⚠️ Please verify that this bug has NOT been reported before.

[X] I checked all existing issues and didn't find a similar issue

Description

Colorizer does not attach when opening a buffer, when running :ColorizerAttachToBuffer it correctly highlights colors

👟 Reproduction steps

minimal reproducible example:

{
  inputs = {
    nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable";
    nvf.url = "github:notashelf/nvf";
  };

  outputs = {
    self,
    nixpkgs,
    ...
  } @ inputs: {
    packages."x86_64-linux" = {
      default =
        (inputs.nvf.lib.neovimConfiguration {
          modules = [
            {
              config.vim.theme.enable = true;
              config.vim.ui.colorizer.enable = true;
            }
          ];
          inherit (nixpkgs.legacyPackages."x86_64-linux") pkgs;
        })
        .neovim;
    };
  };
}

nix run

type 'green' or 'red' -> no color highlighting run :ColorizerAttachToBuffer -> color highlighting

👀 Expected behavior

Colorizer should work without explicitly attaching it to the buffer

😓 Actual Behavior

It did not attach to the buffer

💻 Metadata

system: "x86_64-linux" - host os: Linux 6.6.58, NixOS, 24.11 (Vicuna), 24.11.20241029.807e915 - multi-user?: yes - sandbox: yes - version: nix-env (Lix, like Nix) 2.91.0 System type: x86_64-linux Additional system types: aarch64-linux, i686-linux Features: gc, signed-caches System configuration file: /etc/nix/nix.conf User configuration files: /home/jasper/.config/nix/nix.conf:/etc/xdg/nix/nix.conf:/home/jasper/.nix-profile/etc/xdg/nix/nix.conf:/nix/profile/etc/xdg/nix/nix.conf:/home/jasper/.local/state/nix/profile/etc/xdg/nix/nix.conf:/etc/profiles/per-user/jasper/etc/xdg/nix/nix.conf:/nix/var/nix/profiles/default/etc/xdg/nix/nix.conf:/run/current-system/sw/etc/xdg/nix/nix.conf Store directory: /nix/store State directory: /nix/var/nix Data directory: /nix/store/xjcvjdif1fv2zdsywa2g2r2rahymqbdm-lix-2.91.0/share - nixpkgs: /nix/store/m68ikm8045fj7ys7qvgr608z9l70hh1k-source

📝 Relevant log output

no clue how to get nvim logs tbh

NotAShelf commented 3 hours ago

nvf does not enable the names feature for colorizer by default. You will need to enable it manually in colorizer.setupOpts. See: https://github.com/NotAShelf/nvf/blob/main/modules/plugins/ui/colorizer/colorizer.nix

Jappie3 commented 3 hours ago

even adding colorizer.setupOpts.names = true;:

{
  inputs = {
    nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable";
    nvf.url = "github:notashelf/nvf";
  };

  outputs = {
    self,
    nixpkgs,
    ...
  } @ inputs: {
    packages."x86_64-linux" = {
      default =
        (inputs.nvf.lib.neovimConfiguration {
          modules = [
            {
              config.vim.theme.enable = true;
              config.vim.ui.colorizer = {
                enable = true;
                setupOpts.names = true;
              };
            }
          ];
          inherit (nixpkgs.legacyPackages."x86_64-linux") pkgs;
        })
        .neovim;
    };
  };
}

it still does not attach to the buffer automatically, I manually have to run :ColorizerAttachToBuffer

NotAShelf commented 3 hours ago

That is unusual, I'll take a look shortly.

Jappie3 commented 2 hours ago

also color highlighting by name (e.g. 'blue', 'green') worked with the first flake example I posted... so either my system config (where it is enabled) is leaking (which could also mean that there's some incompatibility) or something weird is happening...

NotAShelf / nvf