search

NotAdam / Lumina.Excel

Do What The F*ck You Want To Public License
12 stars 2 forks source link

The Key field in the Achievement sheet seems to be wrong? #8

Closed TomestoneGG closed 2 hours ago

TomestoneGG commented 2 hours ago

Working on getting Tomestone's Lumina-based extractor working again, and I noticed the Key field in the Achievement sheet seems to always be untyped, implying that the value being switched on in this generated code is possibly wrong?

public RowRef Key => _003Cpage_003EP.ReadUInt8(_003Coffset_003EP + 62) switch
    {
        2 => RowRef.Create<Achievement>(_003Cpage_003EP.Module, (uint)_003Cpage_003EP.ReadInt32(_003Coffset_003EP + 12), _003Cpage_003EP.Language),
        3 => RowRef.Create<ClassJob>(_003Cpage_003EP.Module, (uint)_003Cpage_003EP.ReadInt32(_003Coffset_003EP + 12), _003Cpage_003EP.Language),
        6 => RowRef.Create<Quest>(_003Cpage_003EP.Module, (uint)_003Cpage_003EP.ReadInt32(_003Coffset_003EP + 12), _003Cpage_003EP.Language),
        7 => RowRef.Create<ClassJob>(_003Cpage_003EP.Module, (uint)_003Cpage_003EP.ReadInt32(_003Coffset_003EP + 12), _003Cpage_003EP.Language),
        8 => RowRef.Create<Map>(_003Cpage_003EP.Module, (uint)_003Cpage_003EP.ReadInt32(_003Coffset_003EP + 12), _003Cpage_003EP.Language),
        9 => RowRef.Create<Quest>(_003Cpage_003EP.Module, (uint)_003Cpage_003EP.ReadInt32(_003Coffset_003EP + 12), _003Cpage_003EP.Language),
        11 => RowRef.Create<GrandCompany>(_003Cpage_003EP.Module, (uint)_003Cpage_003EP.ReadInt32(_003Coffset_003EP + 12), _003Cpage_003EP.Language),
        14 => RowRef.Create<InstanceContent>(_003Cpage_003EP.Module, (uint)_003Cpage_003EP.ReadInt32(_003Coffset_003EP + 12), _003Cpage_003EP.Language),
        15 => RowRef.Create<BeastTribe>(_003Cpage_003EP.Module, (uint)_003Cpage_003EP.ReadInt32(_003Coffset_003EP + 12), _003Cpage_003EP.Language),
        18 => RowRef.Create<GrandCompany>(_003Cpage_003EP.Module, (uint)_003Cpage_003EP.ReadInt32(_003Coffset_003EP + 12), _003Cpage_003EP.Language),
        20 => RowRef.Create<AetherCurrentCompFlgSet>(_003Cpage_003EP.Module, (uint)_003Cpage_003EP.ReadInt32(_003Coffset_003EP + 12), _003Cpage_003EP.Language),
        24 => RowRef.Create<Quest>(_003Cpage_003EP.Module, (uint)_003Cpage_003EP.ReadInt32(_003Coffset_003EP + 12), _003Cpage_003EP.Language),
        _ => RowRef.CreateUntyped((uint)_003Cpage_003EP.ReadInt32(_003Coffset_003EP + 12), _003Cpage_003EP.Language),
    };

This was tested with Lumina 5.3.0 and Lumina.Excel 7.1.0.

TomestoneGG commented 2 hours ago

Ah, never mind, pilot error.