Open Critical-Impact opened 5 days ago
Just adding these issues so people are aware and we can track them as they'll need to be fixed before the next major dalamud release.
Easiest way to replicate:
GameData.GetExcelSheet<GatheringPointBase>()!.GetRow(30); var name = gpb.GatheringType.ValueNullable?.Name ?? "test";
It appears to be using the GatheringPointBase's page's language which is None but GatheringType requires a language to be passed in.
At a guess we'd need to grab the module's default language but I think we should also be able to request a row of a specific language
I ran into this today and reported it to Asriel in #dalamud-dev. Apparently she already has it fixed locally and will PR it soon. 🙂
Just adding these issues so people are aware and we can track them as they'll need to be fixed before the next major dalamud release.
Easiest way to replicate:
It appears to be using the GatheringPointBase's page's language which is None but GatheringType requires a language to be passed in.
At a guess we'd need to grab the module's default language but I think we should also be able to request a row of a specific language