Fix RowRef behavior on unknown languages; Add RawRow and RawSubrow

NotAdam / Lumina

A simple, performant and extensible framework for interacting with FFXIV game data

Do What The F*ck You Want To Public License

101 stars 52 forks source link

Fix RowRef behavior on unknown languages; Add RawRow and RawSubrow #95

Closed WorkingRobot closed 3 weeks ago

Haselnussbomber commented 4 weeks ago

I PR'd the suggestions to your fork instead, because the suggestions here didn't include using directives:

https://github.com/WorkingRobot/Lumina/pull/6

Haselnussbomber commented 4 weeks ago

I think the only thing still missing is a way to get rows from RawExcelSheet (which you get from calling GameData.Excel.GetRawSheet()).

WorkingRobot commented 4 weeks ago

I think the only thing still missing is a way to get rows from RawExcelSheet (which you get from calling GameData.Excel.GetRawSheet()).

ExcelSheet has a constructor for this very reason. You can use new ExcelSheet<RawRow>(rawSheet).GetRow(...). Ideally, if you only want to work with raw rows/subrows, use ExcelModule.GetSheet<RawRow/RawSubrow>(lang, name) explicitly.