search

NotDeadYetContributors / NotDeadYet

.NET application health checking made easy
72 stars 15 forks source link

Support Dot net core #13

Closed flytzen closed 5 years ago

flytzen commented 7 years ago

This PR adds support for Dot Net Core as per #7. Specifically, the four packages now use the VS 2017 .csproj format so they can be built using dotnet pack.
The core NotDeadYet package multi-targets Net 4.0 as well as Net Standard 1.6 so it can be used from either full framework or .Net Core.

There is a CreatePackages.cmd but it will likely need adapting to handle versioning sensibly with whatever build chain is in use.

darkfadr commented 5 years ago

looks like there are merge conflicts on this PR, is that what's holding up the merge?

flytzen commented 5 years ago

@darkfadr No, I think the project is dead; the only commits seem to be automated ones. In any case, this PR is now dead and has been superseded by #20

darkfadr commented 5 years ago

@flytzen thanks for the feedback, will try and contact the maintainers to see if something can be done about #20