Making doker_pull compatible with python3

NotGlop / docker-drag

Download image from the Docker Hub HTTPS API

GNU General Public License v3.0

675 stars 191 forks source link

Making doker_pull compatible with python3 #3

Closed jeffque closed 5 years ago

jeffque commented 5 years ago

The major changes were:

print as a function
module io contains StringIO, not StringIO anymore
treat bytes stuff like bytes (such as BytesIO and wb as file-mode to open the proper file)
encode 'utf-8' string when needed (aka line 68)

jeffque commented 5 years ago

So, when I testes this I got a seg fault... don't know why nor in which line

NotGlop commented 5 years ago

Thank you for the update. Did you fix the seg fault or do you still have the issue?

Few remarks: Line 49: should be not be treated as bytes (it is a plain text json config file) Line 68: why do you want to UTF8 encode the sha256 hash?

Edit: Ok that is due to python changes to requests (it returns bytes and not string anymore)

Other modifications are alright for me.

jeffque commented 5 years ago

Requested changes commited

Did you fix the seg fault or do you still have the issue?

Unfortunatly, I still has no idea where this seg fault came in and also have not tested yet (yep, commited blindly)