search

NotJustin / SkillAutoBalance

12 stars 3 forks source link

Late load support #44

Closed xhaooy closed 3 years ago

xhaooy commented 3 years ago

hi, could you add late load support? atm i have those issues: on map where this plugin(s) is loaded [sab/sab-core.smx] Attempting to use score from plugin kento_rankme, but it is not loaded and when i unload this plugin(s) players cannot use teammenu and they are assigned automatically, no error logs

NotJustin commented 3 years ago

Thank you for posting this. You have revealed a problem for me.

I check when the scoretype convar is changed when the plugin is loaded. If the scoretype is not auto, I immediately check if the scoretype you want to use is loaded. If it didn't load yet, then it will show the error you see.

I need to make sure to only check the scoretype after OnConfigsExecuted (which only occurs after all plugins are loaded).

Will push a hotfix in a couple of minutes.

xhaooy commented 3 years ago

thanks :)

NotJustin commented 3 years ago

Please reopen if you notice the issue still occurs.

xhaooy commented 3 years ago

sorry for delay. now i have this again: [sab/sab-core.smx] Attempting to use score from plugin kento_rankme, but it is not loaded

its on late load. when plugin(s) is unloaded everything is fine

NotJustin commented 3 years ago

This whole time, I've been using the library 'kento_rankme' when I should've been using the library 'rankme'.

So, kento rankme scoretype NEVER WORKED until today.

Embarassing for me. 👎