Following a common standard

NotLuksus / nft-art-generator

A tool to generate generative NFT art projects.

MIT License

1.62k stars 532 forks source link

Following a common standard #7

Closed Turupawn closed 3 years ago

Turupawn commented 3 years ago

Changes:

Added a metadata/ and images/ folder
Removed the .json file extension

This is to make it easier to comply to the latest default URI generator by OpenZeppelin https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC721/ERC721.sol#L92

Cheers!

ghost commented 3 years ago

Nice, I've been planning to write a script to split the metadata.json into their individual json files. Thanks for this!

Turupawn commented 3 years ago

Great to hear! Thank you for creating this!

Turupawn commented 3 years ago

Feel free to merge or just grab ideas and close this PR but please let me know so I can create a youtube video about this. I'm sure that people will find a lot of value

ghost commented 3 years ago

You must have misunderstood haha, I'm not the person who created this repo, that's @NotLuksus ! I'm just another user!

Turupawn commented 3 years ago

lol

NotLuksus commented 3 years ago

Could you create an input using iquirer asking the user if they want it in one or in multiple files

Turupawn commented 3 years ago

Could you create an input using iquirer asking the user if they want it in one or in multiple files

Sure! I can do it

Turupawn commented 3 years ago

@NotLuksus Just added the iquirer

Turupawn commented 3 years ago

And btw, after the other PR was merged it started asking for a minimist library Cannot find module 'minimist' So I had to npm install minimist Can you please add it to the dependency list?

Other than that it looks ready to go for me, again please let me know what you think.

NotLuksus commented 3 years ago

Thank you for the contribution, will add minimist to the dependency list!