search

NotNite / DistantSeas

Dalamud plugin that aims to improve Ocean Fishing
GNU Affero General Public License v3.0
8 stars 7 forks source link

Voyage Missions are incorrect #1

Open mikazuki4649 opened 1 year ago

mikazuki4649 commented 1 year ago

Voyage missions on game are different from what shows up in the plugin window. Image attached. image

NotNite commented 1 year ago

I've been aware of this issue, but have a hard time reproducing the bug. My apologies!

CurtisSheu commented 1 year ago

I believe this issue occurs if you do multiple ocean boats in the same session without restarting the FFXIV client.

The listed voyage missions have the old mission text (So for example, "Catch crabs" if that was your mission 1 in the previous area) and the old mission objective (So 0/13 if the previous boat you were on was Bloodbrine Night for example) but it will be updated correctly using whatever your current Journey's actual Mission 1 is. So for example if your current journey is actually Northern Straight of Melthior Night, whose actual first mission is Catch Jellyfish and Crabs 0/7, whenever you catch a jellyfish or crab, it will update the text to "Catch Crabs 1/13".

I haven't done FFXIV plug-in development but I was looking over the code to see if I could find an obvious reason for this. I believe the culprit might be that in the FrameWorkUpdate(), it only seems to update the MissionState state variable if the MissionState list is empty, and I don't see any event that empties out the list.

I confirmed this by doing a third boat and my third boat's missions were the same as the Bloodbrine boat I had done two journeys beforehand. image